Type changes for complex sectors + BlockIterator fix
#26
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 55.74% 55.71% -0.04%
==========================================
Files 18 18
Lines 1410 1418 +8
==========================================
+ Hits 786 790 +4
- Misses 624 628 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Thanks for this!
Small comment about formatting: I think sectortype is exported by TensorKit, so there is no need to specify TK.sectortype.
Similarly, I think it's fair to just import sectorscalartype from TensorKit, and avoid having to explicitly deal with the additional dependency/compat entries. I'll file a PR to TensorKit to make that public/exported anyways.
|
I made use of your TensorKit PR to remove the Sectors dependency. Since I don't really know how compat works in the Project.toml, should the TensorKit one now be specified to 0.14.9? |
|
Since this function existed before, you don't have to update the compat, but you have to explicitly import it to be compatible with the previous versions. Can you also bump the patch version? I'll merge and tag once this is done. |
2 participants
The changes run parallel to the ones done in QuantumKitHub/TensorKit.jl#247 to deal with complex sectors correctly, as well as the
BlockIterator.